feat: prevent schema check approval when policy errors are present

[adambenhassen]

Closes #7037

Linting errors prevent schema check approvals (correct behavior), but the error returned is generic: "Schema check doesn't exist." This makes it unclear why approval failed.

This also includes a bug fix where schema policy errors could be bypassed with safe changes included.

[gemini-code-assist]

Summary of Changes

Hello @adambenhassen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the schema check approval workflow by introducing more descriptive error messages when policy violations are detected, guiding users more effectively. Additionally, it rectifies a critical flaw that previously permitted schema checks with policy errors to proceed to approval, thereby strengthening the integrity of schema policy enforcement.

Highlights

• Improved Error Messaging: Enhanced the error message returned when a schema check approval fails due to existing schema policy errors, providing a clearer reason instead of a generic 'Schema check doesn't exist' message.
• Bug Fix: Policy Error Bypass: Resolved a bug that allowed schema policy errors to be bypassed during the approval process, ensuring that all policy violations are properly enforced.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request addresses an issue where schema check approvals were failing due to linting errors, but the error message was too generic. It also fixes a bug where schema policy errors could be bypassed with safe changes. The changes involve modifying the SchemaManager class to provide a more specific error message when schema policy errors are present and updating the storage logic to prevent bypassing schema policy errors.

[n1ru4l]

@adambenhassen can you please reopen this pull request from this repository, not your fork?

Aside from that can you please add a integration test for this fix?

[adambenhassen]

@adambenhassen can you please reopen this pull request from this repository, not your fork?

Aside from that can you please add a integration test for this fix?

Absolutely, I had permission issues and had to resort to forking. Should be resolved now.
Will add an integration fix 👍