-
Notifications
You must be signed in to change notification settings - Fork 165
Run tests against .NET 7 #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Will review shortly. I'm fighting with email all these days. |
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net6</TargetFramework> | ||
| <TargetFramework>net7</TargetFramework> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
net7 here and net7.0 in some other places. Let's use net7 in all projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using net7.0 as this is the standard and, when using net7, VS adds new tests to unusable location in test browser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VS adds new tests to unusable location in test browser
Could you share a screenshot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that I'm fine switching to net7.0 instead of net7 although I am used to the second.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attempting to run the new test from the test browser will fail because when VS compiles the code, it will appear under the "net7" tfm and so will not run.
With the targetframework set to net7.0, the new test is added to the proper section in the first place, and so it can be selected and run immediately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not new; it has done this for a long time. I've just never bothered to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And after rebuild everything becomes as it should?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So long as we use the recommended TFMs (net7.0, etc) then it works in the first place.
tests/Authorization.AspNetCore.Tests/Authorization.AspNetCore.Tests.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Codecov Report
@@ Coverage Diff @@
## master #954 +/- ##
=======================================
Coverage 95.11% 95.11%
=======================================
Files 42 42
Lines 2087 2087
Branches 359 359
=======================================
Hits 1985 1985
Misses 59 59
Partials 43 43 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@sungam3r ok to merge? |
|
ok |

Uh oh!
There was an error while loading. Please reload this page.