Skip to content

Conversation

@Shane32
Copy link
Member

@Shane32 Shane32 commented Nov 8, 2022

  • Few changes to samples so they compile with updated analysis rules
  • No changes to main codebase
  • No additional targeted TFMs for main codebase

@Shane32 Shane32 self-assigned this Nov 8, 2022
@Shane32 Shane32 requested a review from sungam3r November 9, 2022 16:12
@sungam3r
Copy link
Member

sungam3r commented Nov 9, 2022

Will review shortly. I'm fighting with email all these days.


<PropertyGroup>
<TargetFramework>net6</TargetFramework>
<TargetFramework>net7</TargetFramework>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

net7 here and net7.0 in some other places. Let's use net7 in all projects.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using net7.0 as this is the standard and, when using net7, VS adds new tests to unusable location in test browser

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VS adds new tests to unusable location in test browser

Could you share a screenshot?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that I'm fine switching to net7.0 instead of net7 although I am used to the second.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member Author

@Shane32 Shane32 Nov 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attempting to run the new test from the test browser will fail because when VS compiles the code, it will appear under the "net7" tfm and so will not run.

With the targetframework set to net7.0, the new test is added to the proper section in the first place, and so it can be selected and run immediately.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not new; it has done this for a long time. I've just never bothered to fix it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And after rebuild everything becomes as it should?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long as we use the recommended TFMs (net7.0, etc) then it works in the first place.

Shane32 and others added 2 commits November 17, 2022 02:23
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
@codecov-commenter
Copy link

Codecov Report

Merging #954 (eead476) into master (c83ceac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #954   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          42       42           
  Lines        2087     2087           
  Branches      359      359           
=======================================
  Hits         1985     1985           
  Misses         59       59           
  Partials       43       43           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Shane32
Copy link
Member Author

Shane32 commented Nov 17, 2022

@sungam3r ok to merge?

@Shane32 Shane32 merged commit ea4f0f9 into master Nov 17, 2022
@Shane32 Shane32 deleted the net7 branch November 17, 2022 07:50
@sungam3r
Copy link
Member

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants