Fix call to UseApolloTracing in Complex sample #903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shane32
commented
Aug 17, 2022
| .AddUserContextBuilder(context => new Dictionary<string, object?> { { "user", context.User.Identity!.IsAuthenticated ? context.User : null } }) | ||
| .AddGraphTypes(typeof(ChatSchema).Assembly)); | ||
| .AddGraphTypes(typeof(ChatSchema).Assembly) | ||
| .UseApolloTracing(_ => Environment.IsDevelopment())); |
Member
Author
There was a problem hiding this comment.
The call to UseApolloTracing was moved to the bottom of the list, not because it executes differently, but because it is more similar to how ASP.NET Core is ordered -- and this is the order it will be executed in.
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
=======================================
Coverage 95.17% 95.17%
=======================================
Files 42 42
Lines 1991 1991
Branches 336 336
=======================================
Hits 1895 1895
Misses 55 55
Partials 41 41 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sungam3r
approved these changes
Aug 17, 2022
Kent-Chen-Conning
added a commit
to Conning/graphql-dotnet-server
that referenced
this pull request
Oct 28, 2022
…4-upgrade-to-7.1 * commit 'af5ac03f9f5505d476850cee23c5aaa145110c94': (352 commits) Update response content type for `ExecutionResultActionResult` (graphql-dotnet#923) Bump Serilog.Sinks.Console from 4.0.1 to 4.1.0 (graphql-dotnet#924) Select return content type based on Accept header (graphql-dotnet#919) Allow the configuration of the response content type via options (graphql-dotnet#913) Change default response content type to match draft spec (graphql-dotnet#918) Add note regarding ASP.NET Core 2.1 support policy (graphql-dotnet#914) Bump Microsoft.NET.Test.Sdk from 17.3.0 to 17.3.1 (graphql-dotnet#920) Bump Shouldly from 4.0.3 to 4.1.0 (graphql-dotnet#912) Bump GraphQL to 7.0.2 (graphql-dotnet#911) Add file upload/download documentation to readme (graphql-dotnet#909) Fix packing readme and analysis recommendations (graphql-dotnet#897) Fix call to UseApolloTracing in Complex sample (graphql-dotnet#903) Add docs link Update migration document link (graphql-dotnet#895) Add federation tracing extension method (graphql-dotnet#894) Bump to GraphQL.NET 7.0.0 (graphql-dotnet#893) Feature/assembly-strongname (graphql-dotnet#892) Add JWT bearer authentication sample (graphql-dotnet#885) Bump Microsoft.AspNetCore.TestHost from 6.0.0 to 6.0.8 (graphql-dotnet#889) Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.3.0 (graphql-dotnet#890) ... # Conflicts: # src/Transports.AspNetCore/GraphQLExtensions.cs # src/Transports.AspNetCore/GraphQLHttpMiddleware.cs # src/Transports.AspNetCore/Transports.AspNetCore.csproj # src/Transports.Subscriptions.Abstractions/ProtocolMessageListener.cs # src/Transports.Subscriptions.Abstractions/Subscription.cs # src/Transports.Subscriptions.Abstractions/SubscriptionServer.cs # src/Transports.Subscriptions.Abstractions/Transports.Subscriptions.Abstractions.csproj # src/Transports.Subscriptions.WebSockets/GraphQlWebSocketsMiddleware.cs # src/Transports.Subscriptions.WebSockets/Transports.Subscriptions.WebSockets.csproj # src/Transports.Subscriptions.WebSockets/WebSocketConnection.cs # src/Transports.Subscriptions.WebSockets/WebSocketReaderPipeline.cs # src/Ui.GraphiQL/Ui.GraphiQL.csproj # src/Ui.Playground/Ui.Playground.csproj # src/Ui.Voyager/Ui.Voyager.csproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.