Change order of UI extension method arguments #862
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the UI middleware extension methods should require the path first and then the options, rather than the other way around. I believe this just makes logical sense that you would define the endpoint address and then configure it. Plus it matches the argument ordering of the
UseGraphQLmethod (both now and previously).Also I generally find that it works best when optional method arguments are additive to existing/required arguments, and this change fixes that issue as well.
This will require a note in the migration doc ( #854 ) if it is merged.
Some other options:
Since we have a large number of changes going into v7, perhaps now is a good time to make this change.