Skip to content

Remove Authorization dependency on Core#750

Merged
Shane32 merged 2 commits intodevelopfrom
remove_dependency
Mar 17, 2022
Merged

Remove Authorization dependency on Core#750
Shane32 merged 2 commits intodevelopfrom
remove_dependency

Conversation

@Shane32
Copy link
Member

@Shane32 Shane32 commented Mar 16, 2022

No description provided.

@Shane32 Shane32 requested a review from sungam3r March 16, 2022 21:08
@Shane32 Shane32 self-assigned this Mar 16, 2022
Copy link
Member

@sungam3r sungam3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It became possible after GraphQLRequest/OperationMessage rework, right?

@Shane32
Copy link
Member Author

Shane32 commented Mar 17, 2022

It became possible after GraphQLRequest/OperationMessage rework, right?

Honestly I don't know. I'm not sure that the authorization library needed those classes either. I would have to guess that it is possible because IGraphQLBuilder was moved to GraphQL.NET.

@Shane32 Shane32 merged commit c226f3a into develop Mar 17, 2022
@Shane32 Shane32 deleted the remove_dependency branch March 17, 2022 17:00
@sungam3r
Copy link
Member

Right, it's about builder.

@sungam3r sungam3r added enhancement New feature or request dependencies Pull requests that update a dependency file labels Mar 17, 2022
@sungam3r sungam3r added this to the v6 milestone Apr 14, 2022
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.24%. Comparing base (231b8a5) to head (8021cdb).
⚠️ Report is 208 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #750   +/-   ##
========================================
  Coverage    47.24%   47.24%           
========================================
  Files           55       55           
  Lines         1653     1653           
  Branches       178      178           
========================================
  Hits           781      781           
  Misses         824      824           
  Partials        48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants