Add AuthenticatedSchemes option #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1047 +/- ##
==========================================
- Coverage 93.44% 92.40% -1.04%
==========================================
Files 44 45 +1
Lines 2180 2224 +44
Branches 367 379 +12
==========================================
+ Hits 2037 2055 +18
- Misses 102 124 +22
- Partials 41 45 +4
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+296
to
+303
| foreach (var scheme in _options.AuthenticationSchemes) | ||
| { | ||
| var result = await context.AuthenticateAsync(scheme); | ||
| if (result != null && result.Succeeded) | ||
| { | ||
| newPrincipal = SecurityHelper.MergeUserPrincipal(newPrincipal, result.Principal); | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
See: