Skip to content

Fix SDLPrinter to include operation type for queries with variables #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shane32 merged 2 commits into from
Feb 2, 2026
Merged

Fix SDLPrinter to include operation type for queries with variables #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8a9c83
Fix SDLPrinter to include operation type for queries with variables
Shane32 Feb 2, 2026
d3598e6
Merge branch 'master' into printqueryfix
Shane32 Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/GraphQLParser.Tests/Visitors/SDLPrinterFromParsedTextTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1066,6 +1066,7 @@ public void UTF8_MemoryStream_Runs_Synchronously()
[Theory]
[InlineData("{ field1 }", "{\n field1\n}\n")]
[InlineData("query { field1 }", "{\n field1\n}\n")]
[InlineData("query ($arg: String) { field1 }", "query ($arg: String){\n field1\n}\n")]
[InlineData("query q1 { field1 }", "query q1 {\n field1\n}\n")]
[InlineData("mutation { field1 }", "mutation {\n field1\n}\n")]
[InlineData("mutation m1 { field1 }", "mutation m1 {\n field1\n}\n")]
Expand Down
2 changes: 1 addition & 1 deletion src/GraphQLParser/Visitors/SDLPrinter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ protected override async ValueTask VisitFieldAsync(GraphQLField field, TContext
protected override async ValueTask VisitOperationDefinitionAsync(GraphQLOperationDefinition operationDefinition, TContext context)
{
await VisitAsync(operationDefinition.Comments, context).ConfigureAwait(false);
if (operationDefinition.Name is not null || operationDefinition.Operation != OperationType.Query)
if (operationDefinition.Name is not null || operationDefinition.Operation != OperationType.Query || operationDefinition.Variables is not null)
{
await VisitAsync(LiteralNode.Wrap(GetOperationType(operationDefinition.Operation)), context).ConfigureAwait(false);
await context.WriteAsync(" ").ConfigureAwait(false);
Expand Down
Loading