Skip to content

Add initial comment support [resurrected] #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 20, 2019

Conversation

sungam3r
Copy link
Member

This is a duplicate of #16 with resolved test issues

@joemcbride
Copy link
Member

Would you mind making the \r\n thing cross-platform? Use Environment.NewLine. That way these tests can still be ran on macOS. (I do most of my dev on macOS)

@joemcbride joemcbride merged commit de9ffa2 into graphql-dotnet:master Mar 20, 2019
@sungam3r
Copy link
Member Author

Thanks!

Now, as I understand it, I need a new version of this library to use it in GraphQL package to bring comment support?

Also, will you have time to look at #23 and #24 ?

@sungam3r sungam3r deleted the comments branch March 20, 2019 21:10
@joemcbride
Copy link
Member

Yes will need a new version. I can get those other PRs merged and publish a new nuget.

@sungam3r
Copy link
Member Author

Probably first it will be a prerelease nuget (for checking any unforeseen errors) which I can use in prerelease GraphQL or immediately release version? I do not really understand a good release strategy for dependent stacks of libraries.

@joemcbride
Copy link
Member

@sungam3r I pushed 3.1.0-preview-39 of GraphQL-Parser to nuget.

This was referenced Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants