Skip to content

Conversation

@SimonCropp
Copy link
Contributor

we are getting a null reference on ResolveConnectionContext since it uses the the constructor of ResolveFieldContext which does not duplicate the User

@sungam3r sungam3r added the bugfix Pull request that fixes a bug label Aug 23, 2022
@sungam3r
Copy link
Member

Ooops, we really forgot to add it here.

@sungam3r sungam3r merged commit 7824438 into graphql-dotnet:master Aug 23, 2022
@SimonCropp
Copy link
Contributor Author

@sungam3r thanks. ETA on a release? since i could not find a way to work around this one

@Shane32
Copy link
Member

Shane32 commented Aug 23, 2022

I’m fine with releasing 7.0.2 immediately. I can do it or @sungam3r

@sungam3r ok?

@SimonCropp
Copy link
Contributor Author

thanks so much

@sungam3r
Copy link
Member

ok, I'm a bit busy as usual last months

@SimonCropp SimonCropp deleted the user-not-duplicated-in-context branch August 23, 2022 12:40
Kent-Chen-Conning added a commit to Conning/graphql-dotnet that referenced this pull request Oct 28, 2022
…TRAC-6694-upgrade-graphql-dotnet-server-to-7.1

* commit '13da37d7c0649cc6186714a6671272af49f06d85': (1255 commits)
  Add type integrity check when existing types are found (graphql-dotnet#3332)
  Switch to Nullability.Source (graphql-dotnet#3314)
  Add missing authorization extensions from field and connection builders (graphql-dotnet#3324)
  Prevent using graphtype as model (graphql-dotnet#3316)
  Remove init-only properties from pre-.NET 5 targets (graphql-dotnet#3323)
  Update UnionGraphType to support CLR references (graphql-dotnet#3320)
  Bump BenchmarkDotNet from 0.13.1 to 0.13.2 (graphql-dotnet#3313)
  Bump Microsoft.NET.Test.Sdk from 17.3.0 to 17.3.1 (graphql-dotnet#3311)
  Fix InputFieldsAndArgumentsOfCorrectLength validation rule (graphql-dotnet#3307)
  Bump Shouldly from 4.0.3 to 4.1.0 (graphql-dotnet#3304)
  Add test (graphql-dotnet#3302)
  !(a is T) -> a is not T (graphql-dotnet#3300)
  User not duplicated in context (graphql-dotnet#3298)
  Bump deps (graphql-dotnet#3295)
  Restore `Field<TGraphType>()` method (graphql-dotnet#3294)
  Include v7 migration document link in readme (graphql-dotnet#3290)
  Bump GraphQL-Parser to 8.1.0 (graphql-dotnet#3289)
  Migration notes updates (graphql-dotnet#3287)
  Simplify configuration (graphql-dotnet#3286)
  Introduce ErrorInfoProviderOptions.ExposeExceptionDetailsMode (graphql-dotnet#3276)
  ...

# Conflicts:
#	docs/package.json
#	src/GraphQL/GraphQL.csproj
#	src/GraphQL/Types/GraphTypesLookup.cs
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.01%. Comparing base (5c4c956) to head (d48fe33).
⚠️ Report is 552 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3298   +/-   ##
=======================================
  Coverage   84.00%   84.01%           
=======================================
  Files         376      376           
  Lines       16178    16179    +1     
  Branches     2600     2600           
=======================================
+ Hits        13590    13592    +2     
+ Misses       1971     1970    -1     
  Partials      617      617           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants