Skip to content

Add an interface for websocket specific transport methods. #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/GraphQL.Client.Abstractions.Websocket/IGraphQLClient.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
namespace GraphQL.Client.Abstractions.Websocket;

public interface IGraphQLWebSocketClient : IGraphQLClient
{
/// <summary>
/// Publishes all exceptions which occur inside the websocket receive stream (i.e. for logging purposes)
/// </summary>
IObservable<Exception> WebSocketReceiveErrors { get; }

/// <summary>
/// Publishes the websocket connection state
/// </summary>
IObservable<GraphQLWebsocketConnectionState> WebsocketConnectionState { get; }

/// <summary>
/// Explicitly opens the websocket connection. Will be closed again on disposing the last subscription.
/// </summary>
Task InitializeWebsocketConnection();
}
2 changes: 1 addition & 1 deletion src/GraphQL.Client/GraphQLHttpClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

namespace GraphQL.Client.Http;

public class GraphQLHttpClient : IGraphQLClient, IDisposable
public class GraphQLHttpClient : IGraphQLWebSocketClient, IDisposable
{
private readonly Lazy<GraphQLHttpWebSocket> _lazyHttpWebSocket;
private GraphQLHttpWebSocket GraphQlHttpWebSocket => _lazyHttpWebSocket.Value;
Expand Down