net5 TFM #87
Merged
net5 TFM #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/AspNetCore/Example/Example.csproj
Shane32
reviewed
Feb 27, 2022
| Query = provider.GetRequiredService<StarWarsQuery>(); | ||
| Mutation = provider.GetRequiredService<StarWarsMutation>(); | ||
| Query = (StarWarsQuery)provider.GetService(typeof(StarWarsQuery)) ?? throw new InvalidOperationException(); | ||
| Mutation = (StarWarsMutation)provider.GetService(typeof(StarWarsMutation)) ?? throw new InvalidOperationException(); |
There was a problem hiding this comment.
Long time ago we removed GetRequiredService extension method from GraphQL.NET codebase.
Shane32
approved these changes
Feb 27, 2022
This was referenced Feb 27, 2022
Closed
Shane32
reviewed
Feb 27, 2022
Comment on lines
+23
to
+29
| #pragma warning disable CS0612 // Type or member is obsolete | ||
| services | ||
| .AddGraphQL(options => options.EnableMetrics = true) | ||
| .AddErrorInfoProvider(opt => opt.ExposeExceptionStackTrace = true) | ||
| .AddSystemTextJson() | ||
| .AddUserContextBuilder(httpContext => new GraphQLUserContext { User = httpContext.User }); | ||
| #pragma warning restore CS0612 // Type or member is obsolete |
There was a problem hiding this comment.
Should use non-obsolete methods.
There was a problem hiding this comment.
I'll change usages after April release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.