Skip to content

Allow UnionTypeComposer #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Allow UnionTypeComposer #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89253f3
init
theasmoth Aug 6, 2021
9713738
chore: fix typescript definitions
nodkz Aug 6, 2021
73b94a4
feat: allow ScalarTypeComposer & EnumTypeComposer to be as source TC
nodkz Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/pagination.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,23 @@ import { Resolver, inspect } from 'graphql-compose';
import type {
ObjectTypeComposer,
InterfaceTypeComposer,
UnionTypeComposer,
ScalarTypeComposer,
EnumTypeComposer,
ResolverResolveParams,
ObjectTypeComposerArgumentConfigMap,
} from 'graphql-compose';
import { preparePaginationTC } from './types';

export const DEFAULT_RESOLVER_NAME = 'pagination';
export const DEFAULT_PER_PAGE = 20;
const ALLOWED_TYPE_COMPOSERS = [
'ObjectTypeComposer',
'InterfaceTypeComposer',
'UnionTypeComposer',
'ScalarTypeComposer',
'EnumTypeComposer',
];

export type PaginationResolverOpts = {
findManyResolver: Resolver;
Expand Down Expand Up @@ -40,12 +50,19 @@ export interface PaginationTArgs {
}

export function preparePaginationResolver<TSource, TContext>(
tc: ObjectTypeComposer<TSource, TContext> | InterfaceTypeComposer<TSource, TContext>,
tc:
| ObjectTypeComposer<TSource, TContext>
| InterfaceTypeComposer<TSource, TContext>
| UnionTypeComposer<TSource, TContext>
| ScalarTypeComposer<TContext>
| EnumTypeComposer<TContext>,
opts: PaginationResolverOpts
): Resolver<TSource, TContext, PaginationTArgs> {
if (!tc || tc.constructor.name !== 'ObjectTypeComposer') {
if (!tc || !ALLOWED_TYPE_COMPOSERS.includes(tc.constructor.name)) {
throw new Error(
'First arg for prepareConnectionResolver() should be instance of ObjectTypeComposer'
`First arg for preparePaginationResolver() should be instance of ${ALLOWED_TYPE_COMPOSERS.join(
' or '
)}`
);
}

Expand Down
10 changes: 9 additions & 1 deletion src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ import {
ObjectTypeComposer,
SchemaComposer,
InterfaceTypeComposer,
UnionTypeComposer,
ScalarTypeComposer,
EnumTypeComposer,
} from 'graphql-compose';

// PaginationInfo should be global
Expand Down Expand Up @@ -41,7 +44,12 @@ export function preparePaginationInfoTC<TContext>(
}

export function preparePaginationTC<TSource, TContext>(
tc: ObjectTypeComposer<TSource, TContext> | InterfaceTypeComposer<TSource, TContext>,
tc:
| ObjectTypeComposer<TSource, TContext>
| InterfaceTypeComposer<TSource, TContext>
| UnionTypeComposer<TSource, TContext>
| ScalarTypeComposer<TContext>
| EnumTypeComposer<TContext>,
resolverName?: string
): ObjectTypeComposer<TSource, TContext> {
const schemaComposer = tc.schemaComposer;
Expand Down