Updated express-graphql and deps #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sibelius
approved these changes
Apr 21, 2020
|
@chentsulin could it be possible to have some feeback from you, or possibly allow contributors to actually contribute to this project, please? I'm hitting a bug and my solution is to either for you to merge and update this on npm, me to clone and create another package on npm (you know, duplication pollution of the ecosystem...) or switch to express. I don't want the latter because this would mean days of refactoring the app. The easiest solution would be to have contributors have access to this repository and publishing on npm. Ideally, this package should ideally be moved to the GraphQL organization. |
sibelius
reviewed
Apr 27, 2020
sibelius
approved these changes
Apr 27, 2020
|
Can this be merged now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long needed update. All tests passing.