Merged
Conversation
…s explicit dependencies These packages contain address book files required by @graphprotocol/toolshed but were not declared as dependencies. Adding them explicitly resolves the 'Address book path not found' errors in tests. Both packages added at version 0.4.1 (latest).
The newer version of strip-ansi (v7) uses ES modules which causes Jest to fail. Updated transformIgnorePatterns to transform strip-ansi and ansi-regex modules.
pcarranzav
changed the title
Updated test reference files to include the three new columns added in the horizon branch: - publicPOI and poiBlockNumber (added in commit 325d6fa) - isLegacy (added in commit d2bfd5b) This fixes the failing actions tests in CI. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
tmigone
approved these changes
Jul 28, 2025
Member
tmigone
left a comment
tmigone
left a comment
There was a problem hiding this comment.
lgtm!
We should switch to use the address book package once we have it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes TypeScript compilation errors in indexer-cli tests by adding the required
isLegacyproperty to Action model test data.Also adds
@graphprotocol/horizonand@graphprotocol/subgraph-serviceas explicit dependencies to resolve address book issues.Context
The
Actionmodel in indexer-common now requires anisLegacyproperty, but the test utility in indexer-cli was creating Action records without this property, causing TypeScript compilation errors.The
@graphprotocol/toolshedpackage requires@graphprotocol/horizonand@graphprotocol/subgraph-servicefor their address book files, but these weren't declared as dependencies. This caused "Address book path not found" errors when running tests.Changes
isLegacy: falseto both Action.create() calls inpackages/indexer-cli/src/__tests__/util.ts@graphprotocol/horizonv0.4.1 and@graphprotocol/subgraph-servicev0.4.1 as explicit dependencies to indexer-commonTest Results
After these changes:
Note
Adding these packages as explicit dependencies avoids the circular dependency issue discovered in graphprotocol/contracts#1210
🤖 Generated with Claude Code