firehose: fix optimism check in extended blocks check#6662
Open
YaroShkvorets wants to merge 1 commit into
Open
firehose: fix optimism check in extended blocks check#6662YaroShkvorets wants to merge 1 commit into
YaroShkvorets wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
provides_extended_blocks()matches onoptimism-mainnet, while on Firehose endpoints by convention we are usingoptimismid from the Networks Registry. Same as in Graph Explorer and elsewhere in The Graph ecosystem.This PR just changes the hardcoded value for Optimism but IMO the cleaner way would be to just check for
starts_with("extended")without hardcoding Optimism and Arbitrum ONE chain names at all.Can change to that if needed.