WIP: Make all store/db interactions async #6194
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutter
force-pushed
the
lutter/async-store
branch
3 times, most recently
from
52f8a39 to
a8c347b
Compare
Same for load_deployment and drop_deplyment
lutter
force-pushed
the
lutter/async-store
branch
from
662b957 to
bd58d19
Compare
lutter
force-pushed
the
lutter/async-store
branch
from
9099d6c to
b132fe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of places where we do blocking database work from a non-blocking tokio task. This PR addresses this longstanding issue by using async database connections and
diesel_async. With that, we don't need to rely on error-prone approaches that require spawning blocking tasks whenever we do database work.Most of this PR is concerned with sprinkling async/await throughout the code base. There are a lot of commits, but most of them are boring, and I tried to structure it so that many of them just add async/await in a few places to make them easy to review individually.
Fixes #905