runner: Change transact block error mesage #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoyvens
commented
Apr 1, 2022
| @@ -149,7 +149,7 @@ pub enum IngestorError { | |||
| ReceiptUnavailable(H256, H256), | |||
|
|
|||
| /// An unexpected error occurred. | |||
| #[error("Ingestor error: {0}")] | |||
There was a problem hiding this comment.
This is an unrelated improvement to print ingestor errors with causes.
evaporei
approved these changes
Apr 1, 2022
| data_sources, | ||
| deterministic_errors, | ||
| ) | ||
| .context("Failed to transact block operations")?; |
There was a problem hiding this comment.
Will this create multiple lines like @lutter mentioned the other day? 🤔
There was a problem hiding this comment.
Only if printed as {:?}, and the places that print this use {:#} and actually explicitly remove any newlines that sneak in due to wasm stack traces
graph-node/core/src/subgraph/runner.rs
Line 719 in 102a96b
leoyvens
force-pushed
the
leo/change-transact-block-err-msg
branch
from
b261c8a to
c3432bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove the match by leveraging
contextand?. Read with whitespace diff disabled.