Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deployment head state from instance manager #3241

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

evaporei
Copy link
Contributor

This removes the deployment head state from the instance manager which
could be a point of failure since it wasn't being updated in reverts,
etc.

And moves the stop block logic right after we progress a block since we
don't store the state anymore.

@evaporei evaporei requested a review from leoyvens February 11, 2022 16:34
@evaporei evaporei self-assigned this Feb 11, 2022
…gic after it's processed

This removes the deployment head state from the instance manager which
could be a point of failure since it wasn't being updated in reverts,
etc.

And moves the stop block logic right after we progress a block since we
don't store the state anymore.
@evaporei evaporei force-pushed the otavio/remove-deployment-head-state branch from 4f52da7 to dddfbb7 Compare February 11, 2022 16:39
@evaporei evaporei requested a review from sduchesneau February 11, 2022 16:39
@evaporei evaporei merged commit b744153 into master Feb 11, 2022
@evaporei evaporei deleted the otavio/remove-deployment-head-state branch February 11, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants