all: Limit the 'skip' parameter in the same way as 'first'#1912
Merged
all: Limit the 'skip' parameter in the same way as 'first'#1912
Conversation
leoyvens
approved these changes
Sep 23, 2020
lutter
force-pushed
the
lutter/limit-skip
branch
from
fb18b01 to
93addc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the ability to enforce a global limit on the
skipparameter in queries, in the same way that we limitfirst. This is prompted by the hosted service where we see queries with absurdly highskipvalues (10000 and more) SinceGRAPH_GRAPHQL_MAX_SKIPdefaults tou32::MAXthis change will not do anything for now, though we should absolutely limitskipto something like 2000. Apps should only page through collections withfirst/skipto display them to humans, where 2000 items is more than any human will ever want to look at.If an app needs to download an entire collection, it should not do that with
first/skipas that will perform very badly for larger collections. Instead, it should follow the approach described here In addition, we should give apps a way to poll for updates to a collection they downloaded as described here