Skip to content

Fix search regression #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Fix search regression #465

merged 2 commits into from
Aug 10, 2023

Conversation

benface
Copy link
Contributor

@benface benface commented Aug 10, 2023

This PR fixes a regression in the search feature caused by the removal of a span, which causes most search results to show "#Link to this section". 😬

CleanShot 2023-08-09 at 22 03 03@2x

@benface benface requested a review from a team as a code owner August 10, 2023 02:03
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is for reference only, but I've made the change on the Algolia Crawler admin.

@saihaj
Copy link
Member

saihaj commented Aug 10, 2023

I still see it if u type one word

CleanShot 2023-08-09 at 21 08 26

@benface
Copy link
Contributor Author

benface commented Aug 10, 2023

@saihaj – Unfortunately the fix won't be visible locally, because this PR needs to be deployed and the crawler to be restarted for the index to update. You'll just have to trust that it works. 😅

@github-actions
Copy link

📦 Next.js Bundle Analysis for @graphprotocol/docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 650.18 KB (🟡 +13 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@benface benface merged commit f4423c2 into main Aug 10, 2023
@benface benface deleted the benface/fix-search branch August 10, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants