ID must be unique for UmlClassDiagram

[clemens-tolboom]

I somehow needed to do

$ git diff
diff --git a/lib/Fhaculty/Graph/Loader/UmlClassDiagram.php b/lib/Fhaculty/Graph/Loader/UmlClassDiagram.php
index 63e5035..2d15650 100644
--- a/lib/Fhaculty/Graph/Loader/UmlClassDiagram.php
+++ b/lib/Fhaculty/Graph/Loader/UmlClassDiagram.php
@@ -65,7 +65,7 @@ class UmlClassDiagram extends Base
         } else {
             $reflection = new ReflectionClass($class);
         }
-        $vertex = $this->graph->createVertex($class);
+        $vertex = $this->graph->createVertex($class, TRUE);

         $parent = $reflection->getParentClass();
         if ($parent) {

I feeded it with get_declared_classes();

  $loader = new UmlClassDiagram();
  try {
    foreach ($classes as $class) {
      $loader->createVertexClass($class);
    }
  }
  catch (Exception $exc) {
    return $exc->getMessage();
  }

My test environment is a little tricky so I was wondering how we test this easier.

BTW awesome UML generator.

• http://build2be.com/content/views-core-awesome-uml-route
• http://build2be.com/content/graphviz-blockstorageunittest

[clue]

Thanks for your report.

I'm not entirely sure if that's the right way to do it either.

$loader->createVertexClass('A');
$loader->createVertexClass('A');

In accordance to how Graph::createVertex() works, you'd probably expect it to fail because you're using a duplicate ID, right? That's the current behavior, so far.

But the issue probably stems from the fact that createVertexClass() also automatically creates vertices for super classes. This may not be entirely obvious, but makes the API more convenient to use.

So your above code can be fixed by adding a hasVertexClass() check before calling createVertexClass(). IMHO this sounds sane, but it's a bit inconvenient.

So maybe we should provide an additional convenience method instead? Perhaps something like createVerticesClasses(array $classes) that does all this magic? Also, how to proceed with additional super classes not given in the array?

[clemens-tolboom]

Thanks for the answer and sorry for the late reply. I need to test this soon.

[clue]

The UmlClassDiagram is in the process of being moved to a separate repo (#38). Migrating this ticket to clue/graph-uml#2.