Skip to content

Improve assertions and testing class name #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

peter279k
Copy link
Contributor

Changed log

  • Using the assertCount to assert expected count is same as result.
  • Modify some class name to let them be same as file name.

@clue clue added this to the v0.9.0 milestone Mar 24, 2021
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peter279k Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit ef65a9e into graphp:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants