fix(common): cache selectively

[cjorge-graphops]

we should not be caching values in, say global as they can use component-dependent context like .componentName. At least not until we make this smarter.

Summary by CodeRabbit

• Chores
  • Updated the Helm chart to version 0.0.1-canary.2.
• Refactor
  • Improved internal template processing to boost performance and stability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request includes two main changes. First, it increments the version number in the Helm chart from 0.0.1-canary.1 to 0.0.1-canary.2 in the chart definition file. Second, it refines the caching logic in the preprocessTemplate function within a utility file. The update introduces boolean flags to conditionally enable caching for dependency paths matching specific patterns (i.e., "Self" or "ComponentValues") and ensures that cached results are used when available, with updated comments clarifying the new flow.

Changes

File	Change Summary
charts/common/Chart.yaml	Incremented version from 0.0.1-canary.1 to 0.0.1-canary.2 in adherence to Semantic Versioning guidelines.
charts/common/.../_utils.tpl	Refined caching in the preprocessTemplate function by introducing conditional checks using boolean flags for paths matching "Self" or "ComponentValues", along with updated comments.

Sequence Diagram(s)

sequenceDiagram
    participant Caller as Template Processor
    participant Func as preprocessTemplate
    participant Cache as Cache System

    Caller->>Func: Call preprocessTemplate(path)
    Func->>Func: Check if path matches regex ("Self"/"ComponentValues")
    alt Caching enabled
        Func->>Cache: Lookup cache (constructed key)
        alt Cache Hit
            Cache-->>Func: Return cached value
            Func-->>Caller: Return cached evaluation result
        else No Cache Hit
            Func->>Func: Resolve template value
            Func->>Cache: Store resolved value
            Func-->>Caller: Return resolved value
        end
    else Caching not enabled
        Func->>Func: Resolve template value
        Func-->>Caller: Return resolved value
    end

Loading

Possibly related PRs

• feat(firehose-ethereum): rework JWT without lookup #361: Updates the version number in a Chart.yaml file, similar to the version increment change implemented here.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e2029e and c3ce914.

📒 Files selected for processing (2)

• charts/common/Chart.yaml (1 hunks)
• charts/common/templates/functions/_utils.tpl (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.