Skip to content

feat(heimdall): dumb-init to avoid leftover zombies #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(heimdall): dumb-init to avoid leftover zombies #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/heimdall/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.2.4
version: 1.2.5

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 1 addition & 1 deletion charts/heimdall/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Deploy and scale [Heimdall](https://github.com/maticnetwork/heimdall) inside Kubernetes with ease

[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0) ![Version: 1.2.4](https://img.shields.io/badge/Version-1.2.4-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.0.10](https://img.shields.io/badge/AppVersion-1.0.10-informational?style=flat-square)
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0) ![Version: 1.2.5](https://img.shields.io/badge/Version-1.2.5-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.0.10](https://img.shields.io/badge/AppVersion-1.0.10-informational?style=flat-square)

## Features

Expand Down
10 changes: 6 additions & 4 deletions charts/heimdall/templates/heimdall/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,15 @@ spec:
- -c
- |
set -ex

apk update && apk add --no-cache dumb-init
mv /usr/bin/dumb-init /storage/dumb-init
chmod +x /storage/dumb-init
HEIMDALLD_HOME="/storage"

# If config hasn't been boostrapped already, do it
if [ ! -f "$HEIMDALLD_HOME/config/config.toml" ]; then
# Write out init config for Heimdall
heimdalld --home $HEIMDALLD_HOME init
exec /storage/dumb-init -- heimdalld --home $HEIMDALLD_HOME init
fi

# Replace init genesis with desired network genesis
Expand Down Expand Up @@ -139,7 +141,7 @@ spec:
- -c
- |
set -x
exec heimdalld start \
exec /storage/dumb-init -- heimdalld start \
{{- range $val := initial $heimdallArgs }}
{{ $val }} \
{{- end }}
Expand Down Expand Up @@ -206,7 +208,7 @@ spec:
- -c
- |
set -x;
exec heimdalld rest-server \
exec /storage/dumb-init -- heimdalld rest-server \
{{- range $val := initial $heimdallRestArgs }}
{{ $val }} \
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion charts/heimdall/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ heimdall:
volumeClaimSpec:
accessModes: ["ReadWriteOnce"]
# -- The storage class to use when provisioning a persistent volume for heimdall
storageClassName:
storageClassName:
resources:
requests:
# -- The amount of disk space to provision for Heimdall
Expand Down