Add cache tags support #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have a very similar issue, so interested to see what is necessary for this to get merged. |
Contributor
Author
|
@jkeen , sorry to bother, is there anything I can help you with to merge this PR? |
Collaborator
|
@factyy Sorry for the delay, I think this is good? I'm not sure why that one test is failing though, and it looks like I left this sit for too long and I can't seem to re-run it on CI to make sure it's just an intermittent thing |
Contributor
Author
|
@jkeen , probably it is still good, as far as I remember there weren't any breaking changes... |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
# [1.10.0](v1.9.0...v1.10.0) (2026-01-06) ### Features * add cache tag support to allow context-aware caching ([#498](#498)) ([e8c2bad](e8c2bad))
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original cache implementation relies on two main parts: scope and query.
Quite often we use scoping as a policy-based access control for listing actions like
index. With Graphiti it is easily achieved by making#base_scopecontext-aware (e.g. like checking a requesting user role and restricting access to certain entities for non-admins). The problem is that it is only represented via changes in the DB query object (we have different cache keys for different scopes since they result in different queries). One of the side effects is that Graphiti has no idea about it and cache debugger stubbornly states lots and lots of cache misses (it associates cache keys with the request info that doesn't include any info from the request context).The idea behind this PR is simple: enable cache tagging with a value returned from a resource instance method (that can access request context). This method name has to be passed as a symbol argument to the
cache_resourceresource class method alongsideexpires_inargument.