Fix whisper-fetch.py --drop timestamps#306
Open
cdeil wants to merge 2 commits intographite-project:masterfrom
Open
Fix whisper-fetch.py --drop timestamps#306cdeil wants to merge 2 commits intographite-project:masterfrom
cdeil wants to merge 2 commits intographite-project:masterfrom
Conversation
Member
|
this should work, the wraparounds are handled by whisper.py |
deniszh
reviewed
Nov 12, 2020
deniszh
approved these changes
Nov 12, 2020
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Member
|
Sorry, forgot about this. This is definitely an improvement over the current situation, but the json part is still incorrect as it removes values but does not even have a timestamp, there is no way to know which timestamps have been removed. @cdeil did you have time to test this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #305 .
I didn't test this, not sure if this is correct.
Specifically I don't know how timestamps and offsets in Whisper files work. Is a simple
t + stepappropriate, or is taking into account an offset and wrap-around needed?