conf/entrypoint: fix service disabling #143
Conversation
the "down" file does not instruct runit to not start or stop the service, simply that it should be "normally down". for example with `NGINX_DISABLED`: ``` sv status nginx run: nginx: (pid 125) 364s, normally down ``` ``` / # ps aux|grep nginx 52 root 0:00 runsv nginx 125 root 0:00 nginx: master process /usr/sbin/nginx -c /etc/nginx/nginx.conf 127 nginx 0:00 nginx: worker process 128 nginx 0:00 nginx: worker process 129 nginx 0:00 nginx: worker process 130 nginx 0:00 nginx: worker process ```
|
I would say removing whole directory is that harsh (and unfortunately non-reversable) way to disable service. |
|
Yes, just a quick hax. Runit docs suggest using creating/deleting symlinks to enable/disable services, this solution is not far from it given we use docker containers - it is absolutely reversible as is, just have to down/up the container, the folder will come back. |
|
Maybe some bug in scripts exist but runit documentation says down file should do exactly that:
|
|
Nah, sorry, don't like this hax. Will do that differently. Thanks for patch though, much appreciated! |
|
No worries! Thanks for the project, makes setting it up much easier~
|
|
And btw, disabling Nginx breaking all flow somehow, not sure if it's wise to disable it or graphite-web |
|
Ah, found issue, will fix too |
|
I prefer more explicit change, like #144 |
2 participants
the "down" file does not instruct runit to not start or stop the service, simply that it should be
"normally down".
for example with
NGINX_DISABLED: