Skip to content

Dev/orgs#120

Merged
lmeyerov merged 5 commits into
masterfrom
dev/orgs
Apr 1, 2023
Merged

Dev/orgs#120
lmeyerov merged 5 commits into
masterfrom
dev/orgs

Conversation

@lmeyerov
Copy link
Copy Markdown
Contributor

@lmeyerov lmeyerov commented Mar 31, 2023

Added

  • all: Optional orgs login

Docs

  • all: Arrow uploads and login modes

Published as v4.6.0-alpha.2

@lmeyerov lmeyerov requested a review from aucahuasi March 31, 2023 07:38
* @constructor
* @param {string} username - Graphistry server username
* @param {string} password - Graphistry server password
* @param {string} org - Graphistry organization (optional)
Copy link
Copy Markdown
Contributor

@aucahuasi aucahuasi Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use brackets [] too to indicate that org is optional with the default value undefined:
* @param {string} [org=undefined] - Graphistry organization (optional)

Copy link
Copy Markdown
Contributor

@aucahuasi aucahuasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants