Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport V5 test system to V4 #794

Merged
merged 91 commits into from
Aug 26, 2022
Merged

Backport V5 test system to V4 #794

merged 91 commits into from
Aug 26, 2022

Conversation

benjie
Copy link
Member

@benjie benjie commented May 24, 2022

Description

V5's test system is much more pleasant than V4's; but I'd like to bring the V4 tests across to V5 because they test a lot of edge cases. Thus, I'm backporting the testing system from V5 to V4 so that we can later copy the documents and results back to V5 and check for any regressions.

Performance impact

None, only affects tests.

Security impact

None, only affects tests.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

@benjie benjie marked this pull request as ready for review August 26, 2022 16:12
@benjie benjie merged commit 06dddf8 into v4 Aug 26, 2022
@benjie benjie mentioned this pull request Aug 26, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants