Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphiql): add configurable credentials behavior #1388

Merged
merged 2 commits into from
Nov 13, 2020
Merged

Conversation

benjie
Copy link
Member

@benjie benjie commented Nov 13, 2020

(Maintainer note: accidentally closed #1386 by merging another PR; then couldn't rebase #1387, so opened this one. Author is @eddiewang)

Description

This PR adds the ability to set the Request credential behavior on the GraphiQL instance built into Postgraphile. This allows users that rely on cookies to have a seamless experience querying in GraphiQL.

Performance impact

  • Negligible, adds an extra option in the config.

Security impact

  • Should only be enabled in dev-mode / unknown
  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

@benjie benjie changed the title Add configurable credentials behavior to GraphiQL feat(graphiql): add configurable credentials behavior Nov 13, 2020
@benjie benjie merged commit 61da7e3 into v4 Nov 13, 2020
@benjie benjie deleted the include-credentials branch November 13, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants