Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added forward pass for depth rendering #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JonathonLuiten
Copy link
Contributor

Here are small changes required in this repo to align with the actual changes done in a PR in the renderer repo.

See here:
graphdeco-inria/diff-gaussian-rasterization#2

@grgkopanas
Copy link
Collaborator

Thank you, thats very useful.

We would need to check for regression in speed or add a guard that is by default False to accept this PR

@JonathonLuiten
Copy link
Contributor Author

Hey @grgkopanas and @Snosixtyboo

I ran the speed test on this (tanks and temples / truck for 7000 iterations)

It results in 0 slowdown. I think it's safe to merge this.

Results:

WITH CHANGE:

Training progress: 23%|██▎ | 7000/30000 [02:50<12:04, 31.74it/s, Loss=0.0588340]
[ITER 7000] Evaluating train: L1 0.033260490745306015 PSNR 24.68514633178711 [13/07 15:25:22]

ORIGINAL:

Training progress: 23%|██▎ | 7000/30000 [02:50<12:07, 31.60it/s, Loss=0.0594036]
[ITER 7000] Evaluating train: L1 0.03345547989010811 PSNR 24.60102653503418 [13/07 15:32:42]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants