Skip to content

Conversation

tbenthompson
Copy link

I opened this PR here so that it'll still be your PR that gets merged into cppimport.

  • pre-commit: black, isort, flake8 and corresponding small edits
  • little comment about try_load
  • raise an exception if a concurrent build is detected and force_rebuild is True
  • changed "hook_test.cpp" to "tests/hook_test.cpp". The CI runs the tests from the project root so paths in the tests need to have that form.

See the CI success here: tbenthompson#72 - I'll close that PR after yours is merged. I'm not worried about the codecov decrease. =/

@joshlk joshlk merged commit fe5e0be into graphcore:feature/concurrent_build Jul 8, 2022
@tbenthompson tbenthompson deleted the concurrent_build branch July 15, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants