Skip to content

move symlinks to python, in line with other runtime repos #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

rahult-graphcore
Copy link
Collaborator

This PR duplicates what was done in the other 3 runtimes, to move the symlinking code to a json config and python script, to make it more easily extendable and manageable. Pytorch runtime reference PR: https://github.com/gradient-ai/Graphcore-Pytorch/pull/52/files

Testing done:
Use diff and tree to compare the sorted tree structure of the tmp directory for a Paperspace notebook started using the main branch vs this feature branch, and verify they are identical. Steps:

  1. Created 2 notebooks on paperspace, one on main branch, one on this feature branch. For each notebook, after setup.sh etc. finished executing, start a terminal, then
  2. apt-get update -y && apt-get -y install tree
  3. cd /tmp
  4. tree -afi > /notebooks/<branchname>.tree
  5. Download the 2 .tree files to local machine, then do diff main.tree feature.tree and verify there's no difference between the two.

Copy link
Collaborator

@payoto payoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@payoto
Copy link
Collaborator

payoto commented Mar 30, 2023

Thanks for the detail of how you tested 👌

@rahult-graphcore rahult-graphcore merged commit a561d70 into main Mar 30, 2023
@rahult-graphcore rahult-graphcore deleted the make_symlinks_configurable branch March 30, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants