Tech docs feedback on IPU benchmarks #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

anjleeg-gcai merged 11 commits into main from ipu_benchmark

Apr 6, 2023

Collaborator

anjleeg-gcai commented Mar 27, 2023

No description provided.

anjleeg-gcai added 2 commits

March 27, 2023 16:18


          Opening PR

a6c1c45


          adding review copy

c8dc650

jayniep-gc reviewed

View reviewed changes

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

jayniep-gc reviewed

View reviewed changes

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

jayniep-gc reviewed

View reviewed changes

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

jayniep-gc reviewed

View reviewed changes

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

jayniep-gc reviewed

View reviewed changes

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

jayniep-gc reviewed

View reviewed changes

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

jayniep-gc reviewed

View reviewed changes

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

jayniep-gc reviewed

View reviewed changes

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

anjleeg-gcai and others added 2 commits

April 5, 2023 11:52


          Apply suggestions from code review

4aefa24

Co-authored-by: jayniep-gc <92803120+jayniep-gc@users.noreply.github.com>


          Merge branch 'main' into ipu_benchmark

1e5a304

jayniep-gc suggested changes

View reviewed changes

Collaborator

jayniep-gc left a comment

There was something odd happening with the later comments when (for some reason) there is always an image in the text to be replaced and my changes are not highlighted in the suggestion.

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

ipu-speed-advantage/benchmarking_gnn_on_ipus_review.ipynb Outdated Show resolved Hide resolved

graphcore deleted a comment from jayniep-gc

anjleeg-gcai and others added 4 commits

April 5, 2023 14:11


          Apply suggestions from code review

c913fe3

Co-authored-by: jayniep-gc <92803120+jayniep-gc@users.noreply.github.com>


          Fixing text frm review

7f7742e


          Edits to benchmark section start and end

c969b9d


          reindexing image

1d211da

Collaborator Author

anjleeg-gcai commented Apr 5, 2023 •

edited

Loading

Hi @jayniep-gc , if you approve I will merge this now, I believe I caught everything


          rename after review

7a75db5

jayniep-gc suggested changes

View reviewed changes

Collaborator

jayniep-gc left a comment

There is one minor change to the casing of PopTorch, but otherwise it looks good!

ipu-speed-advantage/benchmarking_gnn_on_ipus.ipynb Outdated Show resolved Hide resolved


          Update ipu-speed-advantage/benchmarking_gnn_on_ipus.ipynb

d572530

Co-authored-by: jayniep-gc <92803120+jayniep-gc@users.noreply.github.com>

jayniep-gc approved these changes

View reviewed changes

Collaborator

jayniep-gc left a comment

Looks good!


          Merge branch 'main' into ipu_benchmark

8905a7a

anjleeg-gcai merged commit 6ef53de into main

anjleeg-gcai deleted the ipu_benchmark branch

April 6, 2023 08:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet