Defer query visitor #154
Merged
Defer query visitor #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...in/java/com/intuit/graphql/orchestrator/visitors/queryVisitors/DeferQueryCreatorVisitor.java
Outdated
Show resolved
Hide resolved
CNAChino
reviewed
Mar 8, 2023
src/main/java/com/intuit/graphql/orchestrator/GraphQLOrchestrator.java
Outdated
Show resolved
Hide resolved
CNAChino
reviewed
Mar 8, 2023
src/main/java/com/intuit/graphql/orchestrator/deferDirective/DeferUtil.java
Outdated
Show resolved
Hide resolved
CNAChino
reviewed
Mar 8, 2023
src/main/java/com/intuit/graphql/orchestrator/deferDirective/DeferUtil.java
Outdated
Show resolved
Hide resolved
CNAChino
reviewed
Mar 8, 2023
src/main/java/com/intuit/graphql/orchestrator/utils/NodeUtils.java
Outdated
Show resolved
Hide resolved
CNAChino
reviewed
Mar 8, 2023
...om/intuit/graphql/orchestrator/visitors/queryVisitors/PruneChildDeferSelectionsModifier.java
Show resolved
Hide resolved
CNAChino
reviewed
Mar 9, 2023
src/main/java/com/intuit/graphql/orchestrator/utils/MultiEIGenerator.java
Show resolved
Hide resolved
CNAChino
reviewed
Mar 9, 2023
...in/java/com/intuit/graphql/orchestrator/visitors/queryVisitors/DeferQueryCreatorVisitor.java
Outdated
Show resolved
Hide resolved
| .selections(selections) | ||
| .build(); | ||
|
|
||
| if(parentNode instanceof Field) { |
Contributor
There was a problem hiding this comment.
there should be a common parent.
Collaborator
Author
There was a problem hiding this comment.
there is a common parent, but i am only checking to cast correctly and use transformer
...in/java/com/intuit/graphql/orchestrator/visitors/queryVisitors/DeferQueryCreatorVisitor.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| //Gets all the definitions for the fragment spreads | ||
| List<FragmentDefinition> fragmentSpreadDefs = neededFragmentSpreads |
Contributor
There was a problem hiding this comment.
move to Util and see if BatchLoader also uses/needs something similar ?
...in/java/com/intuit/graphql/orchestrator/visitors/queryVisitors/DeferQueryCreatorVisitor.java
Outdated
Show resolved
Hide resolved
| ''').build() | ||
|
|
||
| ExecutionResult executionResult = specUnderTest.execute(petsEI, true).get() | ||
| DeferOptions deferOptions = DeferOptions.builder() |
Contributor
There was a problem hiding this comment.
I like deferOptions class
| .map(OperationDefinition::getSelectionSet) | ||
| .map(SelectionSet::getSelections) | ||
| .flatMap(List::stream) | ||
| .forEach(selection -> { |
CNAChino
reviewed
Mar 10, 2023
|
|
||
| @Builder | ||
| public class PruneChildDeferSelectionsModifier extends NodeVisitorStub { | ||
| private DeferOptions deferOptions; |
CNAChino
approved these changes
Mar 10, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Why
Todo: