Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Panic on Introspection of Schema using ToJSON #328

Merged
merged 1 commit into from
May 11, 2019
Merged

Fix Panic on Introspection of Schema using ToJSON #328

merged 1 commit into from
May 11, 2019

Commits on May 8, 2019

  1. Fix Panic on Introspection of Schema using ToJSON 

    Introspection via ToJSON works differently when used via the
 `Schema.ToJSON` function than when making an introspection query from a
 client such as GraphiQL. In the later case, introspection uses the
 Schema's registered resolver, while in the former case, a
 `resolvable.Schema` is faked

Without the `Meta` being set on this `resolvable.Schema` (following the
 recent changes to address race conditions around the Meta schema), this
 resulted in a panic when using this form of schema introspection.
    @dackroyd
    dackroyd committed May 8, 2019
    Configuration menu
    Copy the full SHA
    c126f0e View commit details
    Browse the repository at this point in the history