Check events of type CENSUS as well as OCCUPATION when looking for occupations #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check events of type CENSUS as well as OCCUPATION when looking for occupations.
Update gvrelgraph.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, when an "Include occupation" option is selected, only events of type OCCUPATION are searched. This mod includes events of type CENSUS as well, which usually include occupation information too.
An alternative, far more complex, approach would be to create another option set for "Include census", independent of the "Include occupation" option. However, for most people, this 2 line mod would probably suffice. (Actually, it would have been just a one line mod, but I've just spent 15 minutes going round in circles working out what's wrong with my code formatting style, only to find my one line needs to be split across two with no trailing spaces:-) )