Clean up Gramps localization #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jralls
force-pushed
the
pylint
branch
4 times, most recently
from
b297416
to
2cc2b32
Compare
For name clarity and to reduce the line count in grampslocale.py that Pylint thinks is excessive.
Remove also GrampsLocale.format because it was there only to mirror locale's API, and update GrampsLocale.format_string's signature to match locale.format_string's post-python3.7.
Or comment ones that can't be fixed because their placement is to prevent circular imports.
Short/duplicate variable names, missing docstrings, gratuitous semicolons, excess returns, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Pylint as a guide.
Includes removing python locale API deprecated in 3.7 and 3.11.
Important! In order to comply with PyLint's standards for variable names the
Lexeme.fproperty is renamed toLexeme.forms. This affects translations and I've updated all of them to match. It's unlikely to cause conflicts, but to be safe merge this PR as follows: