Remove SGX_SIGNER_KEY and update manifest files

[anjalirai-intel]

As part of latest gramine SGX_SIGNER_KEY is not required and fs.mount pattern has been updated

Fixes #17

---

This change is 

[mkow]

Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ), one-liner is not in imperative mood (waiting on @anjalirai-intel)

a discussion (no related file):
This needs to wait for the next release, as examples repo should be compatible with the most recent Gramine release (which right now doesn't support this syntax).

---

---

-- commits, line 2 at r1:
One-liners should be in imperative mood. Here you use 2 different tenses/forms in one sentence and none of them is the one we use.

---

openjdk/java.manifest.template, line 24 at r1 (raw file):

sgx.thread_num = 64

# TO-DO: Hardcoded Java path need to be updated, such path does not exist in CentOS

Suggestion (i):

TODO

Suggestion (ii):

needs

Suggestion (iii):

this

Suggestion (iv):

on CentOS.

[anjalirai-intel]

---

-- commits, line 2 at r1:

Previously, mkow (Michał Kowalczyk) wrote…

One-liners should be in imperative mood. Here you use 2 different tenses/forms in one sentence and none of them is the one we use.

Done.

[anjalirai-intel]

---

openjdk/java.manifest.template, line 24 at r1 (raw file):

sgx.thread_num = 64

# TO-DO: Hardcoded Java path need to be updated, such path does not exist in CentOS

Sentence Removed

[mkow]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @anjalirai-intel)

[dimakuv]

Reviewed 13 of 16 files at r1, 1 of 1 files at r2, 1 of 2 files at r3, all commit messages.
Reviewable status: 15 of 16 files reviewed, 3 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @anjalirai-intel and @mkow)

a discussion (no related file):

Previously, mkow (Michał Kowalczyk) wrote…

This needs to wait for the next release, as examples repo should be compatible with the most recent Gramine release (which right now doesn't support this syntax).

+1. The PR itself is good, just needs to be postponed until we release Gramine v1.2 (which contains the new syntax as mentioned in this PR description).

---

---

pytorch/Makefile, line 5 at r3 (raw file):

ARCH_LIBDIR ?= /lib/$(shell $(CC) -dumpmachine)

PILLOW_PATH ?= $(shell pip3 show pillow | grep -P 'Location' | sed 's/Location:.\(.*\)\python.*/\1/')

What's this? This is something new and seemingly irrelevant to this PR... Please explain this addition.

UPDATE: Ok, looks like it is a better way of detecting the magic {{ env.HOME }}/.local/lib directory. Please add a comment before this line (smth like # PyTorch uses the Pillow backend; detect where Pillow was installed)

---

pytorch/pytorch.manifest.template, line 30 at r3 (raw file):

# fs.mount.torch.type = "chroot"
# fs.mount.torch.path = "{{ env.HOME }}/.cache/torch"
# fs.mount.torch.uri = "file:{{ env.HOME }}/.cache/torch"

Please add this as a separate (commented out) line in fs.mounts array, and keep an explanatory comment.

(If this is not possible in TOML syntax, then please change this comment to ask to add the line to fs.mounts)

[anjalirai-intel]

pytorch/Makefile, line 5 at r3 (raw file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

What's this? This is something new and seemingly irrelevant to this PR... Please explain this addition.

UPDATE: Ok, looks like it is a better way of detecting the magic {{ env.HOME }}/.local/lib directory. Please add a comment before this line (smth like # PyTorch uses the Pillow backend; detect where Pillow was installed)

Okay. I will add the comment.

[anjalirai-intel]

pytorch/pytorch.manifest.template, line 30 at r3 (raw file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

Please add this as a separate (commented out) line in fs.mounts array, and keep an explanatory comment.

(If this is not possible in TOML syntax, then please change this comment to ask to add the line to fs.mounts)

Ok

[dimakuv]

Reviewed 1 of 2 files at r3.
Reviewable status: all files reviewed, 3 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @dimakuv and @mkow)

[dimakuv]

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @mkow)

[mkow]

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @anjalirai-intel)

---

-- commits, line 6 at r4:
What's this?

[anjalirai-intel]

-- commits, line 6 at r4:

Previously, mkow (Michał Kowalczyk) wrote…

What's this?

I was testing tensorflow example into another branch. By mistake commit message got updated. Removed it

[dimakuv]

Reviewed 8 of 8 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @anjalirai-intel and @mkow)

---

-- commits, line 6 at r4:

Previously, anjalirai-intel wrote…

I was testing tensorflow example into another branch. By mistake commit message got updated. Removed it

I still see this message. But we can remove this line during final rebase.

[anjalirai-intel]

-- commits, line 6 at r4:

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

I still see this message. But we can remove this line during final rebase.

Gone. Done

[mkow]

Reviewed 7 of 8 files at r5, 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @anjalirai-intel)

[anjalirai-intel]

a discussion (no related file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

+1. The PR itself is good, just needs to be postponed until we release Gramine v1.2 (which contains the new syntax as mentioned in this PR description).

ok

---

[dimakuv]

Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @dimakuv and @mkow)

[anjalirai-intel]

openvino/benchmark_app.manifest.template, line 27 at r7 (raw file):

sgx.trusted_files = [
  "file:benchmark_app",
  "file:{{ gramine.libos }}",

This change is required for Openvino benchmark for SGX.

Without it, it fails with error "error: PAL failed at ../Pal/src/db_main.c:pal_main:543 (exitcode = 6, reason=Unable to load loader.entrypoint)"

[mkow]

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @anjalirai-intel and @dimakuv)

---

openvino/benchmark_app.manifest.template line 27 at r7 (raw file):

Previously, anjalirai-intel wrote…

This change is required for Openvino benchmark for SGX.

Without it, it fails with error "error: PAL failed at ../Pal/src/db_main.c:pal_main:543 (exitcode = 6, reason=Unable to load loader.entrypoint)"

Why did you put this remark as a blocking comment?

[mkow]

Reviewed 4 of 4 files at r8, 8 of 8 files at r9, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @anjalirai-intel and @dimakuv)

[dimakuv]

Reviewed 1 of 1 files at r7, 3 of 4 files at r8, 8 of 8 files at r9, all commit messages.
Dismissed @anjalirai-intel from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved

a discussion (no related file):

Previously, anjalirai-intel wrote…

ok

The release is done. Unblocking now for final merge.

---