Fix resending batched messages #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh wow, I must have missed that when updating to bigInt. good find, Thanks for the PR. |
|
The batched messages part works fine and it did fix some issues. As for the Using version |
|
Ok I needed to update store2. I'll do that in master |
|
Oh, my bad, I was using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug with iterating
Mapvalues, batched messages are never re-sent. This PR fixes it and also corrects a couple of errors related to type checking.I believe this also closes #178. I reproduced the bug when signing in with a phone number that is served by another DC. When reconnecting, a client tries to send
help.GetConfigandMsgsAckmessages in a batch, receives a bad salt message, but never resends them because resending batches is broken (this is why the client also got stuck).