Fix support for python 3.9#5
Merged
graingert merged 1 commit intograingert:defaultfrom Dec 14, 2024
danielnelson:python3.9
Merged
Fix support for python 3.9#5graingert merged 1 commit intograingert:defaultfrom danielnelson:python3.9
graingert merged 1 commit intograingert:defaultfrom
danielnelson:python3.9
Conversation
Collaborator
|
The better IMO way to fix this is to use |
This allows using newer annotation feature while still supporting Python 3.9.
Contributor
Author
|
That's a good idea, I have updated the PR to use this method. |
graingert
approved these changes
Dec 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been using taskgroup for Python versions 3.9 and 3.10, it works quite well. I have run into one issue with the latest
0.0.0a4release on PyPI, I get this error in some situations during cancel:I noticed that HEAD has this fixed, to get it to work with Python 3.9 I just needed to switch some type annotations back to the Python 3.9 style, using
UnionandOptional.