Add fdscan() method to ClamdUnixSocket#19
Open
joelsmith wants to merge 2 commits intograingert:masterfrom
Open
Add fdscan() method to ClamdUnixSocket#19joelsmith wants to merge 2 commits intograingert:masterfrom
joelsmith wants to merge 2 commits intograingert:masterfrom
Conversation
0c23eff to
96f766b
Compare
Author
|
@graingert Please take a look. It looks like the py26 test is failing because no python 2.6 interpreter is available in the test environment. All the other tests are passing (except for pypy, which is skipping the new tests because it lacks the needed functionality in its python for the new feature). Please let me know anything I should do differently. Thanks! |
|
What is the problem with this pull request? @graingert For future readers, the socket module has a |
Owner
|
Please do drop stages for EOL pythons and support only 3.6,3.7,3.8,3.9 and 3.10 You'll probably need to add GitHub actions as Travis is EOL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method is useful when clamd is running as a non-root user
and can't directly open a file that needs to be scanned. In
such cases, the clamd client can open the file and submit
a scan job via the open file descriptor.