Skip to content

Upgrade jsoo #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 29 commits into from
Closed

Upgrade jsoo #2254

wants to merge 29 commits into from

Conversation

hhugo
Copy link
Contributor

@hhugo hhugo commented Mar 20, 2025

No description provided.

@hhugo
Copy link
Contributor Author

hhugo commented Mar 21, 2025

I find the esy workflow quite difficult to deal with...

@ospencer
Copy link
Member

It's usually not so bad. I don't know what's going on here, though.

@hhugo
Copy link
Contributor Author

hhugo commented Mar 21, 2025

The CI is happy on ubuntu https://github.com/hhugo/grain/actions/runs/13989268415/job/39169369435?pr=2

Failing on macos because of cmake
Failing on windows because of ocp-indent

  • I had to add (data_only_dirs node_modules) in compiler/dune, otherwise dune would complain about dune files in compiler/node_modules/ocaml
  • pin binaryen to include jsoo 6 fixes
  • pin dune because it has a with-dev-setup dependencyon a recent version of ppx_expect that is not available on 4.14. I don't understand why esy want to installwith-dev-setup` for dune.
  • the hacks.js files are no longer necessary because already part of the latest release.

The diff in esy.json can probably be cleaned up and reduced. It's the result of many experiment.

@hhugo hhugo mentioned this pull request Mar 21, 2025
@spotandjake
Copy link
Member

On my branch #2233 I got past the ocp-indent issue by vendoring and disabling the test suite, the issue is related to a symlink in the tests censored version here, I think we might need to make a pr handling to the esy opam patches repo handling this behavior correctly, still ran into issues with conf-cmake though.

@hhugo
Copy link
Contributor Author

hhugo commented Mar 21, 2025

In #2255, I left the binaryen dep unchanged and didn't see any issue with dune

@hhugo hhugo closed this Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants