-
-
Notifications
You must be signed in to change notification settings - Fork 118
Upgrade jsoo #2254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade jsoo #2254
Conversation
I find the esy workflow quite difficult to deal with... |
It's usually not so bad. I don't know what's going on here, though. |
The CI is happy on ubuntu https://github.com/hhugo/grain/actions/runs/13989268415/job/39169369435?pr=2 Failing on macos because of cmake
The diff in |
On my branch #2233 I got past the ocp-indent issue by vendoring and disabling the test suite, the issue is related to a symlink in the tests censored version here, I think we might need to make a pr handling to the esy opam patches repo handling this behavior correctly, still ran into issues with conf-cmake though. |
In #2255, I left the binaryen dep unchanged and didn't see any issue with dune |
No description provided.