Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grails.gorm.flushMode should have COMMIT as default value in the documentation #514

Open
andersaaberg opened this issue Feb 23, 2022 · 1 comment
Open

grails.gorm.flushMode should have COMMIT as default value in the documentation #514

andersaaberg opened this issue Feb 23, 2022 · 1 comment

Comments

@andersaaberg
Copy link

In the documentation (https://gorm.grails.org/latest/hibernate/manual/index.html#_configuration_reference), grails.gorm.flushMode has default value AUTO but default value for flushMode was changed to COMMIT in GORM 6.1: https://gorm.grails.org/6.1.0/hibernate/manual/index.html#_flush_mode_now_commit_by_default

The GORM code does have default flushMode set to COMMIT, so the documentation is wrong:
https://github.com/grails/gorm-hibernate5/blob/7.2.x/grails-datastore-gorm-hibernate5/src/main/groovy/org/grails/orm/hibernate/AbstractHibernateDatastore.java#L132
andersaaberg added a commit to andersaaberg/gorm-hibernate5 that referenced this issue Feb 23, 2022
@andersaaberg
grails.gorm.flushMode wrong default value
1a65963 
Default value for grails.gorm.flushMode was changed from AUTO to COMMIT in GORM 6.1, but this was not fixed in the docs as well. Candidate fix for grails#514
@andersaaberg
Copy link
Author

Candidate fix: 7.2.x...andersaaberg:patch-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andersaaberg