Skip to content

Build & Release process cleanup #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Build & Release process cleanup #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8502758
Gradle cleanup
jdaugherty Dec 9, 2024
e5ef637
Fix release workflow to use the correct variables
jdaugherty Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ jobs:
- name: "🚀 Publish to Sonatype OSSRH"
id: publish
env:
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }}
SONATYPE_NEXUS_URL: ${{ secrets.SONATYPE_NEXUS_URL }}
SONATYPE_STAGING_PROFILE_ID: ${{ secrets.SONATYPE_STAGING_PROFILE_ID }}
NEXUS_PUBLISH_USERNAME: ${{ secrets.NEXUS_PUBLISH_USERNAME }}
NEXUS_PUBLISH_PASSWORD: ${{ secrets.NEXUS_PUBLISH_PASSWORD }}
NEXUS_PUBLISH_URL: ${{ secrets.NEXUS_PUBLISH_RELEASE_URL }}
NEXUS_PUBLISH_STAGING_PROFILE_ID: ${{ secrets.NEXUS_PUBLISH_STAGING_PROFILE_ID }}
SIGNING_KEY: ${{ secrets.SIGNING_KEY }}
SIGNING_PASSPHRASE: ${{ secrets.SIGNING_PASSPHRASE }}
SECRING_FILE: ${{ secrets.SECRING_FILE }}
Expand Down Expand Up @@ -98,9 +98,10 @@ jobs:
env:
DEVELOCITY_BUILD_CACHE_NODE_USER: ${{ secrets.DEVELOCITY_BUILD_CACHE_NODE_USER }}
DEVELOCITY_BUILD_CACHE_NODE_KEY: ${{ secrets.DEVELOCITY_BUILD_CACHE_NODE_KEY }}
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }}
SONATYPE_STAGING_PROFILE_ID: ${{ secrets.SONATYPE_STAGING_PROFILE_ID }}
NEXUS_PUBLISH_USERNAME: ${{ secrets.NEXUS_PUBLISH_USERNAME }}
NEXUS_PUBLISH_PASSWORD: ${{ secrets.NEXUS_PUBLISH_PASSWORD }}
NEXUS_PUBLISH_URL: ${{ secrets.NEXUS_PUBLISH_RELEASE_URL }}
NEXUS_PUBLISH_STAGING_PROFILE_ID: ${{ secrets.NEXUS_PUBLISH_STAGING_PROFILE_ID }}
working-directory: ./plugin
run: >
../gradlew
Expand Down
13 changes: 0 additions & 13 deletions examples/audit-test-allow-update-outside-transaction/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
buildscript {
ext {
grailsVersion = project.grailsVersion
}
repositories {
maven { url "https://repo.grails.org/grails/core" }
}
Expand All @@ -14,7 +11,6 @@ plugins {
id "com.bertramlabs.asset-pipeline" version "$assetPipelineVersion"
}


version project.projectVersion
group "audit.test"

Expand All @@ -24,11 +20,6 @@ apply plugin: 'idea'
apply plugin: "org.grails.grails-web"
apply plugin: "org.grails.grails-gsp"

ext {
grailsVersion = project.grailsVersion
gradleWrapperVersion = project.gradleWrapperVersion
}

assets {
minifyJs = true
minifyCss = true
Expand Down Expand Up @@ -79,10 +70,6 @@ dependencies {
testImplementation "org.grails:grails-web-testing-support"
}

task wrapper(type: Wrapper) {
gradleVersion = gradleWrapperVersion
}

test {
testLogging {
showStandardStreams = true
Expand Down
12 changes: 0 additions & 12 deletions examples/audit-test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
buildscript {
ext {
grailsVersion = project.grailsVersion
}
repositories {
maven { url "https://repo.grails.org/grails/core" }
}
Expand All @@ -23,11 +20,6 @@ apply plugin: 'idea'
apply plugin: "org.grails.grails-web"
apply plugin: "org.grails.grails-gsp"

ext {
grailsVersion = project.grailsVersion
gradleWrapperVersion = project.gradleWrapperVersion
}

assets {
minifyJs = true
minifyCss = true
Expand Down Expand Up @@ -78,10 +70,6 @@ dependencies {
testCompileOnly "org.mockito:mockito-core"
}

task wrapper(type: Wrapper) {
gradleVersion = gradleWrapperVersion
}

tasks.withType(Test).configureEach { Task it ->
useJUnitPlatform()

Expand Down
9 changes: 0 additions & 9 deletions plugin/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ apply plugin: "idea"
apply plugin: "org.grails.grails-plugin"
apply plugin: "org.grails.grails-gsp"

ext {
grailsVersion = project.grailsVersion
gradleWrapperVersion = project.gradleWrapperVersion
}

repositories {
mavenLocal()
mavenCentral()
Expand Down Expand Up @@ -62,10 +57,6 @@ dependencies {

bootJar.enabled = false

task wrapper(type: Wrapper) {
gradleVersion = gradleWrapperVersion
}

apply plugin: "org.grails.grails-publish"
grailsPublish {
githubSlug = 'grails-plugins/grails-audit-logging-plugin'
Expand Down
Loading