Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop machine monitoring on Session shutdown #90

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Stop machine monitoring on Session shutdown #90

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e97c750
Use a unique context for each call of Session.Run
Jul 9, 2020
8d262d7
Use shutdown channel instead
Jul 11, 2020
c8933b3
Put context as first argument
Jul 11, 2020
2b4529b
revert debug change to slicer main
Jul 11, 2020
9f1d839
Exit machineManager.Do based on shutdownc
Jul 14, 2020
ac25547
Use background context again
Jul 14, 2020
0eea356
test fixes
Jul 14, 2020
f90c048
add shutdown test
Jul 14, 2020
9486b15
Remove some context plumbing
Jul 14, 2020
dad8604
goimports
Jul 14, 2020
30aabc0
remove final context change
Jul 14, 2020
ca309f3
jerry proposal
Jul 15, 2020
9483e48
lint
Jul 20, 2020
3749a4d
remove defer
Jul 20, 2020
993f92c
remove go.sum changes
Jul 20, 2020
07f2241
Use more idiomatic go func in loop
awiss Jul 20, 2020
6dd809c
Dont return on ctx.Done()
awiss Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove go.sum changes
  • Loading branch information
Alex Wissmann committed Jul 20, 2020
commit 993f92c98c74376b23d13d972b67f4b921c31345
3 changes: 0 additions & 3 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,6 @@ github.com/grailbio/bigmachine v0.5.7 h1:RaYi4wa4el62yqrw1qTB+KVmmlcS8VhDy59/l+8
github.com/grailbio/bigmachine v0.5.7/go.mod h1:wvOUthoZPxKKJ829ClWaO/uRTxaW3DLm7LyUQHO8ed0=
github.com/grailbio/bigmachine v0.5.8 h1:LNOiBTPjk6P8JODqqItcysRzftEPhE59B1wSlKnpGy4=
github.com/grailbio/bigmachine v0.5.8/go.mod h1:O9UMGp6FPD6dRJhpIImjnTs8uFG8smEDYSqdIoadS+Y=
github.com/grailbio/testutil v0.0.1/go.mod h1:j7teGaXqRY1n6m7oM8oy954lxL37Myt7nEJZlif3nMA=
github.com/grailbio/testutil v0.0.3 h1:Um0OOTtYVvyxwQbO48K3t6lNmLPY4sL3Vn6Sw0srNy8=
github.com/grailbio/testutil v0.0.3/go.mod h1:f9+y7xMXeXwyNcdV5cmo6GzRiitSOubMmqcqEON7NQQ=
github.com/grailbio/v23/factories/grail v0.0.0-20190904050408-8a555d238e9a h1:kAl1x1ErQgs55bcm/WdoKCPny/kIF7COmC+UGQ9GKcM=
github.com/grailbio/v23/factories/grail v0.0.0-20190904050408-8a555d238e9a/go.mod h1:2g5HI42KHw+BDBdjLP3zs+WvTHlDK3RoE8crjCl26y4=
github.com/hanwen/go-fuse v1.0.0/go.mod h1:unqXarDXqzAk0rt98O2tVndEPIpUgLD9+rwFisZH3Ok=
Expand Down