Showing an empty tab for Bolt default tabs #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty tabs are shown when you create a field with condition and group/tab titled `Taxonomy`. For some reason there is always an empty div created with attribute `data-bolt-fieldset` for taxonomy tab when it’s used in the CT’s. It looks like it’s Bolt’s default behaviour for that tab. So when you create `taxonomylist` type fields and set their group as `taxonomy` for pages with conditions to show them only on certain page templates, they still appear in all the templates due to that Bolt’s empty fieldset with the empty data attribute for `data-bolt-fieldset`. The fix is to check if the data attribute is not empty when counting the visible fields length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty tabs are shown when you create a field with condition and group/tab titled
Taxonomy.For some reason there is always an empty div created with attribute
data-bolt-fieldsetfor taxonomy tab when it’s used in the CT’s. It looks like it’s Bolt’s default behaviour for that tab.So when you create
taxonomylisttype fields and set their group astaxonomyfor pages with conditions to show them only on certain page templates, they still appear in all the templates due to that Bolt’s empty fieldset with the empty data attribute fordata-bolt-fieldset.The fix is to check if the data attribute is not empty when counting the visible fields length.