Skip to content
This repository was archived by the owner on Oct 11, 2023. It is now read-only.

basic startup file #18

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

basic startup file #18

wants to merge 7 commits into from

Conversation

poig
Copy link
Collaborator

@poig poig commented Nov 16, 2022

#15

@grageragarces
Copy link
Owner

wonderful thank you for starting this @poig

@grageragarces grageragarces added this to the Components milestone Nov 16, 2022
@grageragarces grageragarces added the enhancement New feature or request label Nov 16, 2022
@grageragarces grageragarces linked an issue Nov 16, 2022 that may be closed by this pull request
Build node elements #4
Closed
@grageragarces grageragarces removed a link to an issue Nov 16, 2022
Build node elements #4
Closed
@grageragarces grageragarces linked an issue Nov 16, 2022 that may be closed by this pull request
Enhance the existing list of basic components that a rudimental network should contain #3
Closed
grageragarces
grageragarces approved these changes Dec 16, 2022
View reviewed changes
Copy link
Owner

@grageragarces grageragarces left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good starting structure, we can modify as we move. before merging the following doc conflicts need to be resolved:
src/channels/classical_channel.py
src/channels/quantum_channel.py
src/components/node.py

@grageragarces
Copy link
Owner

I would recommend merging them within the commits - you could easly do this via adding them to your fork, and moving them to the relevant location within the structure

@grageragarces
Copy link
Owner

grageragarces commented Dec 16, 2022 •
edited
Loading

if you're unable to do that please let me know I can look into it. I will modify the review to reflect this

grageragarces
grageragarces suggested changes Dec 16, 2022
View reviewed changes
Copy link
Owner

@grageragarces grageragarces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please modify the following conflicting files through your commits:
src/channels/classical_channel.py
src/channels/quantum_channel.py
src/components/node.py

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@grageragarces grageragarces grageragarces requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@poig poig

@grageragarces grageragarces

Labels

enhancement New feature or request

Projects

None yet

Milestone

Components

Development

Successfully merging this pull request may close these issues.

Enhance the existing list of basic components that a rudimental network should contain

2 participants

@poig @grageragarces