This repository has been archived by the owner on Dec 8, 2024. It is now read-only.
Make comma optional in #EXTINF when strict mode is false #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradleyfalzon
force-pushed
the
extinf-comma
branch
from
070cb6f to
97d2f47
Compare
**This is a potential breaking change** Previously we would skip a segment which doesn't have a comma in the For example, the following playlist would have a single nil segment. #EXTM3U #EXT-X-VERSION:3 #EXT-X-TARGETDURATION:10 c_1267327549363093.ts The new behaviour will cause an error to be returned when parsing if we're operating in strict mode. If we're not operating in strict mode the duration will be parsed successfully as 10.000, with an empty title. Fixes grafov#84.
bradleyfalzon
force-pushed
the
extinf-comma
branch
from
97d2f47 to
f06f0b2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential breaking change
Previously we would skip a segment which doesn't have a comma in the
For example, the following playlist would have a single nil segment.
The new behaviour will cause an error to be returned when parsing if
we're operating in strict mode. If we're not operating in strict mode
the duration will be parsed succesfully as 10.000, with an empty title.
Fixes #84.