This repository has been archived by the owner on Dec 8, 2024. It is now read-only.
Feature: Support MediaSegment@SeqId. #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
| @@ -251,6 +255,15 @@ func TestDecodeMediaPlaylist(t *testing.T) { | |||
| t.Errorf("Segment %v's title = %v (must = %q)", i, s.Title, titles[i]) | |||
| } | |||
| } | |||
| if p.Count() != 522 { | |||
There was a problem hiding this comment.
Isn't better to use an assert here? I'm new to golang anyway
assert.Equal(t, 522, p.Count(), "Expected segments quantity: 522.")There was a problem hiding this comment.
If yes I think there is lots of places where it can be asserted instead of conditional checked.
There was a problem hiding this comment.
Yes Leandro, I use assert to write test cases in some of my projects, it seems good.
But the assert is not contained in Golang's official packages, I do not want to introduce a 3rd package for the time being, I hope keep this project to be simple.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
MediaSegment.SeqIdsupport.